Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/online gw #80

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Fix/online gw #80

merged 3 commits into from
Jun 18, 2022

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Jun 18, 2022

This PR enables online=True in GW without having to set it to False always.
For this, I needed to change the logic of is_fused property a bit.

TODO:

  • add test

closes #79

@marcocuturi
Copy link
Contributor

Thanks Michal!

@marcocuturi marcocuturi merged commit 50a7be3 into ott-jax:main Jun 18, 2022
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catching online=True in gromov_wasserstein
2 participants