-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/batched vmap #588
Feature/batched vmap #588
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 88.00% 88.13% +0.12%
==========================================
Files 73 73
Lines 7820 7768 -52
Branches 567 556 -11
==========================================
- Hits 6882 6846 -36
+ Misses 789 779 -10
+ Partials 149 143 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -105,6 +105,7 @@ def __call__( | |||
dual_initialization, weights=weights, axis=0 | |||
)[jnp.newaxis, :] | |||
|
|||
# TODO(michalk8): geom.is_symmetric is not static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true!
TODOs:
pointcloud.py
(re-order methods/properties, etc.)LRCGeometry
batched_vmap
closes #504