Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor was solver #580

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Feature/refactor was solver #580

merged 14 commits into from
Oct 4, 2024

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Oct 3, 2024

TODOs:

  • update notebooks

@michalk8 michalk8 added the enhancement New feature or request label Oct 3, 2024
@michalk8 michalk8 self-assigned this Oct 3, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michalk8 michalk8 requested a review from marcocuturi October 3, 2024 14:18
@michalk8 michalk8 marked this pull request as ready for review October 3, 2024 14:18
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 87.87%. Comparing base (2240868) to head (ddc6535).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/ott/solvers/quadratic/gromov_wasserstein.py 69.56% 6 Missing and 1 partial ⚠️
src/ott/solvers/was_solver.py 54.54% 5 Missing ⚠️
src/ott/solvers/quadratic/_solve.py 71.42% 1 Missing and 1 partial ⚠️
src/ott/solvers/quadratic/gw_barycenter.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   87.84%   87.87%   +0.03%     
==========================================
  Files          73       73              
  Lines        7838     7813      -25     
  Branches     1132     1127       -5     
==========================================
- Hits         6885     6866      -19     
+ Misses        799      794       -5     
+ Partials      154      153       -1     
Files with missing lines Coverage Δ
src/ott/solvers/linear/continuous_barycenter.py 94.11% <100.00%> (+0.17%) ⬆️
src/ott/solvers/quadratic/gw_barycenter.py 93.20% <75.00%> (+3.82%) ⬆️
src/ott/solvers/quadratic/_solve.py 82.35% <71.42%> (-2.27%) ⬇️
src/ott/solvers/was_solver.py 82.35% <54.54%> (-0.99%) ⬇️
src/ott/solvers/quadratic/gromov_wasserstein.py 88.42% <69.56%> (+1.86%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, LGTM, thanks @michalk8 !

@michalk8 michalk8 merged commit b36a937 into main Oct 4, 2024
12 checks passed
@michalk8 michalk8 deleted the feature/refactor-was-solver branch October 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants