Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to ProgOT #570

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Edits to ProgOT #570

merged 2 commits into from
Aug 13, 2024

Conversation

pkassraie
Copy link
Collaborator

Small edits (almost entirely to documentation) for ProgOT.

@pkassraie pkassraie requested a review from michalk8 August 11, 2024 11:04
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (18bf5be) to head (6d6c002).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
src/ott/tools/progot.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   88.35%   88.40%   +0.04%     
==========================================
  Files          72       72              
  Lines        7695     7718      +23     
  Branches     1099     1107       +8     
==========================================
+ Hits         6799     6823      +24     
+ Misses        745      744       -1     
  Partials      151      151              
Files with missing lines Coverage Δ
src/ott/tools/progot.py 29.37% <50.00%> (+0.29%) ⬆️

... and 5 files with indirect coverage changes

@michalk8 michalk8 added the documentation Improvements or additions to documentation label Aug 11, 2024
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, minor fixes, then LGTM!

src/ott/tools/progot.py Outdated Show resolved Hide resolved
src/ott/tools/progot.py Outdated Show resolved Hide resolved
@michalk8 michalk8 merged commit a97c178 into main Aug 13, 2024
10 of 11 checks passed
@michalk8 michalk8 deleted the feature/progot branch August 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants