Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink div for LR #568

Merged
merged 6 commits into from
Aug 9, 2024

turn on `Danskin`, solve test issue with grad/LR

b66005d
Select commit
Loading
Failed to load commit list.
Merged

sink div for LR #568

turn on `Danskin`, solve test issue with grad/LR
b66005d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2024 in 0s

88.41% (target 1.00%)

View this Pull Request on Codecov

88.41% (target 1.00%)

Details

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (478f034) to head (b66005d).

Files Patch % Lines
src/ott/tools/sinkhorn_divergence.py 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   88.36%   88.41%   +0.05%     
==========================================
  Files          72       72              
  Lines        7699     7716      +17     
  Branches     1102     1107       +5     
==========================================
+ Hits         6803     6822      +19     
+ Misses        745      743       -2     
  Partials      151      151              
Files Coverage Δ
src/ott/math/utils.py 91.30% <100.00%> (+0.19%) ⬆️
src/ott/solvers/linear/sinkhorn_lr.py 98.98% <100.00%> (+0.32%) ⬆️
src/ott/tools/progot.py 29.07% <ø> (ø)
src/ott/tools/sinkhorn_divergence.py 91.66% <90.00%> (+0.62%) ⬆️

... and 1 file with indirect coverage changes