Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of gangbo-mccann map estimators using twist operator #500

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

marcocuturi
Copy link
Contributor

Previous implementation of potential -> Monge map estimator was resting on the TI formula, $T(x) = x - \nabla h^* \circ \nabla f(x)$. This PR opens up the API to handle the more general formula $T(x) = \nabla_{1}c(x,\cdot)^{-1}\circ \nabla f(x)$. This adds twisted_operator methods to arbitrary CostFn.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (cbff1c7) to head (e51ca61).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files          60       60           
  Lines        6687     6688    +1     
  Branches      956      956           
=======================================
+ Hits         6058     6059    +1     
  Misses        480      480           
  Partials      149      149           
Files Coverage Δ
src/ott/geometry/costs.py 92.60% <100.00%> (+0.08%) ⬆️
src/ott/problems/linear/potentials.py 91.44% <100.00%> (-0.22%) ⬇️

@michalk8 michalk8 self-requested a review March 11, 2024 21:14
docs/references.bib Show resolved Hide resolved
src/ott/geometry/costs.py Show resolved Hide resolved
src/ott/problems/linear/potentials.py Outdated Show resolved Hide resolved
src/ott/problems/linear/potentials.py Show resolved Hide resolved
@marcocuturi marcocuturi merged commit b0e809a into main Mar 12, 2024
13 checks passed
@marcocuturi
Copy link
Contributor Author

thanks Michal!

@marcocuturi marcocuturi deleted the gangbo-mccann branch March 12, 2024 11:31
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
* addition of gangbo-mccann map estimators using twist operator

* docs

* docs

* link

* changes after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants