Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentials as tuple #488

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Potentials as tuple #488

merged 9 commits into from
Feb 8, 2024

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Feb 8, 2024

Also removes explicit passing of the dtype and the deprecated solve function.
Fixes some warnings and minor pet-peeves (like missing leading/trailing 0s).

@michalk8 michalk8 self-assigned this Feb 8, 2024
@michalk8 michalk8 added the misc label Feb 8, 2024
@michalk8 michalk8 requested a review from marcocuturi February 8, 2024 16:57
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a10c377) 90.58% compared to head (70c5495) 90.62%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   90.58%   90.62%   +0.04%     
==========================================
  Files          60       60              
  Lines        6678     6678              
  Branches      952      954       +2     
==========================================
+ Hits         6049     6052       +3     
+ Misses        480      478       -2     
+ Partials      149      148       -1     
Files Coverage Δ
src/ott/geometry/costs.py 92.92% <100.00%> (-0.02%) ⬇️
src/ott/geometry/geometry.py 92.69% <100.00%> (-0.03%) ⬇️
src/ott/geometry/graph.py 93.68% <100.00%> (ø)
src/ott/geometry/grid.py 91.53% <ø> (ø)
src/ott/geometry/low_rank.py 97.04% <100.00%> (ø)
src/ott/geometry/pointcloud.py 86.47% <100.00%> (ø)
src/ott/initializers/linear/initializers.py 100.00% <100.00%> (ø)
src/ott/initializers/linear/initializers_lr.py 91.38% <100.00%> (ø)
src/ott/math/matrix_square_root.py 100.00% <100.00%> (ø)
src/ott/math/unbalanced_functions.py 100.00% <100.00%> (ø)
... and 22 more

@michalk8 michalk8 merged commit 8519182 into main Feb 8, 2024
13 checks passed
@michalk8 michalk8 deleted the feature/potentials-as-tuple branch February 8, 2024 22:58
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Add support for `.potentials` for `SinkhornOutput`

* Remove explicit `dtype` casting

* Add leading or trailing 0s

* Fix dtype in test

* Fix typo

* Remove `jnp.atleast_1d` in subsetting

* Fix scalar subsetting

* Fix `flax=0.8.1` docs typos in docs linter

* Fix more pet-peeves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant