-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potentials as tuple #488
Merged
Merged
Potentials as tuple #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 90.58% 90.62% +0.04%
==========================================
Files 60 60
Lines 6678 6678
Branches 952 954 +2
==========================================
+ Hits 6049 6052 +3
+ Misses 480 478 -2
+ Partials 149 148 -1
|
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Add support for `.potentials` for `SinkhornOutput` * Remove explicit `dtype` casting * Add leading or trailing 0s * Fix dtype in test * Fix typo * Remove `jnp.atleast_1d` in subsetting * Fix scalar subsetting * Fix `flax=0.8.1` docs typos in docs linter * Fix more pet-peeves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes explicit passing of the dtype and the deprecated
solve
function.Fixes some warnings and minor pet-peeves (like missing leading/trailing 0s).