Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/apply lse mode #474

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Feature/apply lse mode #474

merged 3 commits into from
Nov 28, 2023

Conversation

michalk8
Copy link
Collaborator

Add lse_mode option to Sinkhorn.apply; useful for kernel geometries.

@michalk8 michalk8 added the enhancement New feature or request label Nov 28, 2023
@michalk8 michalk8 requested a review from marcocuturi November 28, 2023 17:12
@michalk8 michalk8 self-assigned this Nov 28, 2023
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #474 (0dd1c7d) into main (75c6b3d) will decrease coverage by 8.16%.
Report is 1 commits behind head on main.
The diff coverage is 70.58%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   90.47%   82.32%   -8.16%     
==========================================
  Files          60       60              
  Lines        6529     6533       +4     
  Branches      928      636     -292     
==========================================
- Hits         5907     5378     -529     
- Misses        476     1030     +554     
+ Partials      146      125      -21     
Files Coverage Δ
src/ott/solvers/linear/sinkhorn.py 98.14% <100.00%> (+0.02%) ⬆️
src/ott/geometry/graph.py 93.68% <0.00%> (-1.11%) ⬇️
src/ott/geometry/geodesic.py 92.22% <55.55%> (-2.16%) ⬇️

... and 13 files with indirect coverage changes

@michalk8 michalk8 merged commit d84fc79 into main Nov 28, 2023
9 of 11 checks passed
@michalk8 michalk8 deleted the feature/apply-lse-mode branch November 28, 2023 18:38
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Fix tests

* Add `lse_mode` to `SinkhornOutput`

* Update reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants