Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/geodesic sinkhorn #457
Feature/geodesic sinkhorn #457
Changes from 40 commits
d3d840f
4306382
03a57f9
fb4de65
1f3cd9f
9473a68
dd1fd95
8c087f4
408b14c
1e33f10
d901e5c
01eb7e1
f223d7a
7bfa71c
0a3b8c8
c2e5770
c1ec39d
5830ebc
1d06049
8e14cdb
0b7364b
0a22bcd
8bc10c1
3650cda
06d04ef
3e62805
3640e45
4f4447c
2d5e0f0
083b021
406d9c8
9239524
0dd5a97
43df649
acda12b
8bbb19e
d640821
bab7d94
b296da4
b7d1df3
999b226
e19cf01
298c544
7d13198
620245d
3a93b22
3e5ef04
cf17ce4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this, as it's not being used anywhere in the class.
The docs will need to be adapted a bit as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only removed
self.order
, becauseself.t
is used for the attributecost_matrix
, andself.eigval
,self.chebyshev_coeffs
are used inexpm_multiply
. I renamedphi
toeigval
inexpm_multiply
to make it clearer.