Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix n_iters #437

Merged
merged 17 commits into from
Sep 13, 2023
Merged

Fix n_iters #437

merged 17 commits into from
Sep 13, 2023

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Sep 13, 2023 •
edited
Loading

  • fix n_iters in GWOutput
  • add n_iters to LRSinkhornOutput and LRGWOutput
  • remove unnecessary hierarchy in the tutorials
  • remove legacy linear and linear_output properties from SinkhornOutput and LRSinkhornOutput
  • update FenchelConjugateLBFGS to accommodate jaxopt>=0.8
  • fix a few warnings in tests

closes #436

@michalk8 michalk8 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 13, 2023
@michalk8 michalk8 self-assigned this Sep 13, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@michalk8 michalk8 merged commit df96dae into main Sep 13, 2023
@michalk8 michalk8 deleted the feature/n-iters branch September 13, 2023 16:03
michalk8 added a commit that referenced this pull request Jun 27, 2024
@michalk8
Fix n_iters (#437)
0327ae3 
* Start cleaning `n_iters`

* Remove dead code

* Update SD

* Update GW tutorial

* Remove unnecessary hierarchy in tutorials

* Remove `n_iters` property from SD

* Fix not passing `inner_iterations`

* Skip testing `flax` on 3.8

* Fix SD test

* Use `.toarray()`

* Update `FenchelConjugateLBFGS` for `jaxopt>=0.8`

* Fix missing `importorskip`

* Split `MetaInitializer` test

* [ci skip] Fix typos in bary docs

* Skip tests that need `optax`

* Remove relative pip install from MG notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocuturi marcocuturi Awaiting requested review from marcocuturi

Assignees

@michalk8 michalk8

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michalk8