Feature/quadratic solve #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
marcocuturi
reviewed
Sep 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 90.37% 90.46% +0.09%
==========================================
Files 56 57 +1
Lines 6265 6273 +8
Branches 892 893 +1
==========================================
+ Hits 5662 5675 +13
+ Misses 459 454 -5
Partials 144 144
|
marcocuturi
approved these changes
Sep 12, 2023
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "We provide the Average FOSCTTM to align `X` (chromatinaccessibility domain) to `Y` (gene expression domain) for each implementation:" | ||
| "We provide the Average FOSCTTM to align `X` (chromatin accessibility domain) to `Y` (gene expression domain) for each implementation:" |
| @@ -24,23 +24,54 @@ class Loss(NamedTuple): # noqa: D101 | |||
| is_linear: bool | |||
|
|
|||
|
|
|||
| class GWLoss(NamedTuple): # noqa: D101 | |||
| class GWLoss(NamedTuple): | |||
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Add `solve` function for quadratic problems * Update docs * Fix typo in notebook * Fix implicit diff passing in LR Sinkhorn * Fix typo * Clean `GWLoss` docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #432