Feature/lineax ridge #424
Merged
Feature/lineax ridge #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 91.39% 91.40%
=======================================
Files 55 55
Lines 5939 5943 +4
Branches 863 866 +3
=======================================
+ Hits 5428 5432 +4
Misses 375 375
Partials 136 136
|
|
thanks! LGTM for now |
|
Thanks, will just fix the docs linter + add a test! |
marcocuturi
added a commit
that referenced
this pull request
Sep 8, 2023
* Feature/better io callbacks (#413) * Add `tqdm` callback * Polish docs, add examples * Fix LRSink and GW * Update notebook * Update docstrings * Update old tests * More tests * Add `tqdm` to testing requirements * Skip progress fn tests on `jax<0.4` * Fix last callback test * Feature/optional dependencies (#412) * Add `neural` extra requirements * Add import wrappers for neural modules * Update `tox` * Fix linter * Update docs * Pin numpy from above, fix RTD * Update pre-commits (#416) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Feature/move solve (#418) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Move `ott.solvers.linear.sinkhorn.solve` to `linear` * Fix typo * Nicer docs for Sinkhorn output * Fix math * [ci skip] Update docs * Feature/lineax ridge (#424) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Add `ridge` options to `lineax` * Modify test for `lineax` ridge * Fix linkchecker --------- Co-authored-by: michalk8 <[email protected]>
marcocuturi
added a commit
that referenced
this pull request
Sep 11, 2023
* docs * mongegap * mg * mg * more details in monge gap * merge (#414) * Feature/better io callbacks (#413) * Add `tqdm` callback * Polish docs, add examples * Fix LRSink and GW * Update notebook * Update docstrings * Update old tests * More tests * Add `tqdm` to testing requirements * Skip progress fn tests on `jax<0.4` * Fix last callback test * Feature/optional dependencies (#412) * Add `neural` extra requirements * Add import wrappers for neural modules * Update `tox` * Fix linter * Update docs * Pin numpy from above, fix RTD --------- Co-authored-by: michalk8 <[email protected]> * precom * merge (#430) * Feature/better io callbacks (#413) * Add `tqdm` callback * Polish docs, add examples * Fix LRSink and GW * Update notebook * Update docstrings * Update old tests * More tests * Add `tqdm` to testing requirements * Skip progress fn tests on `jax<0.4` * Fix last callback test * Feature/optional dependencies (#412) * Add `neural` extra requirements * Add import wrappers for neural modules * Update `tox` * Fix linter * Update docs * Pin numpy from above, fix RTD * Update pre-commits (#416) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Feature/move solve (#418) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Move `ott.solvers.linear.sinkhorn.solve` to `linear` * Fix typo * Nicer docs for Sinkhorn output * Fix math * [ci skip] Update docs * Feature/lineax ridge (#424) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Add `ridge` options to `lineax` * Modify test for `lineax` ridge * Fix linkchecker --------- Co-authored-by: michalk8 <[email protected]> * n_iters more precise * clarify epsilon param in sinkhorn * epsilon doc * ott pot * ott - pot * add small comment * fix check trees in test * fitting / regularizer losses must return log * spell * improve coverage * fix threshold of total mass * again --------- Co-authored-by: michalk8 <[email protected]>
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Add `ridge` options to `lineax` * Modify test for `lineax` ridge * Fix linkchecker
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* docs * mongegap * mg * mg * more details in monge gap * merge (#414) * Feature/better io callbacks (#413) * Add `tqdm` callback * Polish docs, add examples * Fix LRSink and GW * Update notebook * Update docstrings * Update old tests * More tests * Add `tqdm` to testing requirements * Skip progress fn tests on `jax<0.4` * Fix last callback test * Feature/optional dependencies (#412) * Add `neural` extra requirements * Add import wrappers for neural modules * Update `tox` * Fix linter * Update docs * Pin numpy from above, fix RTD --------- Co-authored-by: michalk8 <[email protected]> * precom * merge (#430) * Feature/better io callbacks (#413) * Add `tqdm` callback * Polish docs, add examples * Fix LRSink and GW * Update notebook * Update docstrings * Update old tests * More tests * Add `tqdm` to testing requirements * Skip progress fn tests on `jax<0.4` * Fix last callback test * Feature/optional dependencies (#412) * Add `neural` extra requirements * Add import wrappers for neural modules * Update `tox` * Fix linter * Update docs * Pin numpy from above, fix RTD * Update pre-commits (#416) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Feature/move solve (#418) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Move `ott.solvers.linear.sinkhorn.solve` to `linear` * Fix typo * Nicer docs for Sinkhorn output * Fix math * [ci skip] Update docs * Feature/lineax ridge (#424) * Update pre-commits * Dedent `tox` in `pyproject.toml` * Temporarily indent again * Run linters * Update for `tox>=4.9.0` * Add `ridge` options to `lineax` * Modify test for `lineax` ridge * Fix linkchecker --------- Co-authored-by: michalk8 <[email protected]> * n_iters more precise * clarify epsilon param in sinkhorn * epsilon doc * ott pot * ott - pot * add small comment * fix check trees in test * fitting / regularizer losses must return log * spell * improve coverage * fix threshold of total mass * again --------- Co-authored-by: michalk8 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs: