tracking progress of gromov-wasserstein #351
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 88.21% 88.20% -0.01%
==========================================
Files 51 51
Lines 5481 5496 +15
Branches 827 829 +2
==========================================
+ Hits 4835 4848 +13
- Misses 527 528 +1
- Partials 119 120 +1
|
|
I'll add to |
There was a problem hiding this comment.
Thanks a lot @bosr , got only very minor comments.
For the tests, we can add this later and am ok merging without.
One question: have you tried passing the callback to GW, as well as it's linear solver? Might be nice to show in the notebook.
|
Thanks @bosr for the contribution - I just fixed some minor issues. |
* tracking progress of gromov-wasserstein * fix: linting issue * fix: do not expose GWState explicitly * Update notebook, fix minor issues --------- Co-authored-by: Michal Klein <[email protected]>
Yet another progress bar PR ;)
GromovWassersteinsolverGWStatein the docs: [EDIT: removed] this actually causes linting issues because it is already exposed viaautosummarySinkhorn,LRSinkhornandGromovWasserstein