-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for unbalanced OT #291
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nina! this looks great. I also think this will need to be added in the rst
files to show up in the docs. Maybe we need some hierarchy.
@@ -0,0 +1,381 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #12. source = gaussian_mixture(
I think these should be renamed source -> x
and target -> y
to be more consistent with the other notebooks?
Reply via ReviewNB
Can you also please add the notebook to the documentation in the appropriate place here? |
Hi Nina! any progress on your end for this notebook? |
Hi Marco,
Sorry for leaving this around, I am on it and will submit a pull request
soon. Thank you very much for your remarks,
Have a nice week !
Le lun. 20 mars 2023 à 14:10, Marco Cuturi ***@***.***> a
écrit :
… Hi Nina! any progress on your end for this notebook?
—
Reply to this email directly, view it on GitHub
<#291 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXA7UANRIGGV5TN5ZDMMG6TW5BJMZANCNFSM6AAAAAAU3335RA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Thank you very much for your comments, it helped me a lot ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nvesseron there seems to be rendering issue in the first cell, can you please fix it?
https://ott-jax--291.org.readthedocs.build/en/291/tutorials/notebooks/Unbalanced_OT.html
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 72 72
Lines 7716 7716
Branches 1107 1107
=======================================
Hits 6822 6822
Misses 743 743
Partials 151 151 |
@nvesseron can you tell me what's the status of this PR? I think it was almost done, am not sure whether the above comments have been addressed though. |
@michalk8 I did change the notebook according to your comments. Do not hesitate to tell me if there is anything else I can do to improve the notebook. Thank you for helping me with that contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @nvesseron , thanks a lot!
I just fixed the Bibtex file + small typos, think we can merge soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks everyone!
I added a tutorial for unbalanced OT and added a reference in the bib that I cite in the tutorial.