Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 D10{1,2,3} errors #269

Merged
merged 10 commits into from
Feb 14, 2023
Merged

Fix flake8 D10{1,2,3} errors #269

merged 10 commits into from
Feb 14, 2023

Conversation

giovp
Copy link
Contributor

@giovp giovp commented Feb 14, 2023 •
edited
Loading

close #250

giovp
giovp commented Feb 14, 2023
View reviewed changes
src/ott/geometry/costs.py Outdated Show resolved Hide resolved
giovp
giovp commented Feb 14, 2023
View reviewed changes
src/ott/geometry/costs.py Outdated Show resolved Hide resolved
@giovp giovp mentioned this pull request Feb 14, 2023
Merged
@giovp giovp marked this pull request as ready for review February 14, 2023 13:49
@giovp
Copy link
Contributor Author

giovp commented Feb 14, 2023 •
edited
Loading

so unfortunately this resolved in adding a ton of # noqa cause apparently flake8 is not smart enough to infer docstrings from inherited classes, see PyCQA/pydocstyle#309 . This is also discussed in ruff astral-sh/ruff#2413 but no solution at the moment.

I tried to add some docstrings where I felt confortable/understood the signature/scope of the function but please double check as I'm not familiar.

This should be merged before #278

@giovp giovp requested a review from michalk8 February 14, 2023 13:54
michalk8
michalk8 requested changes Feb 14, 2023
View reviewed changes
src/ott/geometry/costs.py Outdated Show resolved Hide resolved
src/ott/geometry/costs.py Outdated Show resolved Hide resolved
src/ott/problems/nn/dataset.py Outdated Show resolved Hide resolved
src/ott/solvers/linear/sinkhorn_lr.py Outdated Show resolved Hide resolved
src/ott/tools/gaussian_mixture/gaussian_mixture.py Outdated Show resolved Hide resolved
@giovp giovp requested a review from michalk8 February 14, 2023 14:49
michalk8
michalk8 requested changes Feb 14, 2023
View reviewed changes
src/ott/geometry/costs.py Outdated Show resolved Hide resolved
src/ott/geometry/costs.py Show resolved Hide resolved
src/ott/geometry/costs.py Show resolved Hide resolved
src/ott/geometry/costs.py Outdated Show resolved Hide resolved
src/ott/geometry/costs.py Show resolved Hide resolved
src/ott/geometry/costs.py Show resolved Hide resolved
src/ott/geometry/costs.py Show resolved Hide resolved
@giovp
Copy link
Contributor Author

giovp commented Feb 14, 2023

@michalk8 I re-introduced all tree flatten/unflatten methods to respective costs

@giovp giovp requested a review from michalk8 February 14, 2023 15:02
michalk8
michalk8 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giovp !

@michalk8 michalk8 merged commit 04051db into ott-jax:main Feb 14, 2023
pierreablin pushed a commit to pierreablin/ott that referenced this pull request Feb 14, 2023
@giovp @pierreablin
Fix flake8 D10{1,2,3} errors (ott-jax#269)
8a70047 
* fix D101 and B028 (stack level for warnings) introduced in ott-jax#219

* add vscode to gitignore

* fix D102 on costs.py and try to simplify inheritance methods

* try to fix D102 everywhere

* fix D103

* remove comment from .flake8

* address comments

* more comments

* re-introduce tree-flatten in costs
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
@giovp
Fix flake8 D10{1,2,3} errors (#269)
80f860b 
* fix D101 and B028 (stack level for warnings) introduced in #219

* add vscode to gitignore

* fix D102 on costs.py and try to simplify inheritance methods

* try to fix D102 everywhere

* fix D103

* remove comment from .flake8

* address comments

* more comments

* re-introduce tree-flatten in costs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalk8 michalk8 michalk8 approved these changes

Assignees

@giovp giovp

Labels
hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flake8 D10{1,2,3} errors
2 participants
@giovp @michalk8