Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc/tox #239

Merged
merged 21 commits into from
Jan 31, 2023
Merged

Misc/tox #239

merged 21 commits into from
Jan 31, 2023

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Jan 30, 2023

Update CI and add tox.

TODOs:

  • enable spellchecker (spelling will be fixed in the future)
  • update CONTRIBUTING.rst

@michalk8 michalk8 added the misc label Jan 30, 2023
@michalk8 michalk8 self-assigned this Jan 30, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Merging #239 (a233531) into main (08491f0) will decrease coverage by 3.09%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   87.94%   84.85%   -3.09%     
==========================================
  Files          52       52              
  Lines        5317     5317              
  Branches      546      812     +266     
==========================================
- Hits         4676     4512     -164     
- Misses        510      682     +172     
+ Partials      131      123       -8     
Impacted Files Coverage Δ
src/ott/tools/gaussian_mixture/scale_tril.py 92.47% <ø> (ø)
src/ott/solvers/nn/neuraldual.py 70.37% <50.00%> (ø)
src/ott/geometry/graph.py 31.87% <0.00%> (-60.00%) ⬇️
src/ott/math/decomposition.py 43.20% <0.00%> (-44.00%) ⬇️
src/ott/math/utils.py 84.09% <0.00%> (-9.10%) ⬇️
src/ott/solvers/linear/sinkhorn.py 95.16% <0.00%> (-1.62%) ⬇️
src/ott/geometry/geometry.py 90.87% <0.00%> (-1.31%) ⬇️

@michalk8 michalk8 marked this pull request as ready for review January 31, 2023 11:16
@michalk8 michalk8 requested a review from marcocuturi January 31, 2023 11:26
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@michalk8 michalk8 merged commit 1cb1f9b into ott-jax:main Jan 31, 2023
@michalk8 michalk8 deleted the misc/tox branch January 31, 2023 13:18
@michalk8 michalk8 mentioned this pull request Feb 2, 2023
3 tasks
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Fix most link warnings

* Add initial `tox` config

* Update workflow files

* Fix `3.10` not being escaped

* Fix memray

* Update package publishing

* Remove `tox-gh`, re-add `lint.yml`

* Fix linter, test on `macOS`

* Fix typo

* Change concurrency

* Update pre-commits

* Fix linter

* Add tolerances

* Enable spellchecker

* Fix libenchant installation

* Fix libenchant install v2

* Skip failing test on macOS

* Update `CONTRIBUTING.md`

* Test on Python3.11 as well

* Remove notebook tests

* Mention `pyEnchant`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants