Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/initializers as literals #148

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Feature/initializers as literals #148

merged 2 commits into from
Oct 10, 2022

Conversation

michalk8
Copy link
Collaborator

closes #146

@michalk8 michalk8 added the enhancement New feature or request label Oct 10, 2022
@michalk8 michalk8 self-assigned this Oct 10, 2022
marcocuturi
marcocuturi approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@codecov-commenter
Copy link

Codecov Report

Merging #148 (be6c69c) into main (d238c3f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   89.87%   89.91%   +0.04%     
==========================================
  Files          51       51              
  Lines        4946     4956      +10     
  Branches      502      505       +3     
==========================================
+ Hits         4445     4456      +11     
+ Misses        380      379       -1     
  Partials      121      121
Impacted Files Coverage Δ
ott/core/sinkhorn.py 98.08% <100.00%> (+0.09%) ⬆️
ott/tools/gaussian_mixture/fit_gmm_pair.py 79.26% <0.00%> (-0.25%) ⬇️
ott/core/potentials.py 87.05% <0.00%> (+1.01%) ⬆️

@michalk8
Copy link
Collaborator Author

Codecov upload failed for fast test (same in #145 and #147). In #147 the CI will pass if the tests pass, but upload can now fail (it's not crucial).

@michalk8 michalk8 merged commit 6c79d96 into ott-jax:main Oct 10, 2022
@michalk8 michalk8 deleted the feature/initializers-as-literals branch October 10, 2022 12:27
michalk8 added a commit that referenced this pull request Jun 27, 2024
@michalk8
Feature/initializers as literals (#148)
41b01b9 
* Allow passing `initializer` as a `literal` in Sink

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocuturi marcocuturi marcocuturi approved these changes

Assignees

@michalk8 michalk8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Also allow Sinkhorn initializers to be passed as Literals
3 participants
@michalk8 @codecov-commenter @marcocuturi