Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GMM documentation more visible, fix bug in M step of EM algorithm #144

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Make GMM documentation more visible, fix bug in M step of EM algorithm #144

merged 2 commits into from
Oct 10, 2022

Conversation

geoff-davis
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #144 (37c9393) into main (cca7453) will increase coverage by 7.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   82.77%   89.88%   +7.11%     
==========================================
  Files          51       51              
  Lines        4946     4944       -2     
  Branches      502      502              
==========================================
+ Hits         4094     4444     +350     
+ Misses        702      379     -323     
+ Partials      150      121      -29     
Impacted Files Coverage Δ
ott/tools/gaussian_mixture/fit_gmm_pair.py 79.26% <100.00%> (+2.15%) ⬆️
ott/core/neuraldual.py 70.14% <0.00%> (+0.74%) ⬆️
ott/geometry/grid.py 91.15% <0.00%> (+0.88%) ⬆️
ott/tools/gaussian_mixture/fit_gmm.py 75.60% <0.00%> (+1.21%) ⬆️
ott/geometry/low_rank.py 97.67% <0.00%> (+1.55%) ⬆️
ott/core/quad_initializers.py 89.65% <0.00%> (+1.72%) ⬆️
ott/core/quad_problems.py 88.50% <0.00%> (+2.00%) ⬆️
ott/core/initializers.py 100.00% <0.00%> (+2.12%) ⬆️
ott/core/sinkhorn_lr.py 96.55% <0.00%> (+2.58%) ⬆️
... and 21 more

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Geoff! LGTM

@marcocuturi marcocuturi merged commit 468c2d5 into ott-jax:main Oct 10, 2022
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
#144)

* Make GMM documentation more visible, fix bug in M step of EM algorithm

* Remove unused imports of adhoc_import and importlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants