LR Sinkhorn improvements #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
michalk8
requested changes
Jul 21, 2022
michalk8
requested changes
Jul 25, 2022
Merged
|
@meyerscetbon @marcocuturi you can both review it now, there some TODOs left for me, but not critical |
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 89.45% 83.17% -6.28%
==========================================
Files 47 48 +1
Lines 4580 4713 +133
Branches 503 512 +9
==========================================
- Hits 4097 3920 -177
- Misses 364 650 +286
- Partials 119 143 +24
|
marcocuturi
approved these changes
Aug 31, 2022
michalk8
force-pushed
the
branch_meyer_recovered
branch
from
d7a2a16 to
fb1a1df
Compare
michalk8
pushed a commit
that referenced
this pull request
Jun 27, 2024
* test * update lr-sinkhorn * restored_branch * check * review * circular fixed * update review * Fix bugs in `LRSinkhorn` * Use new `k-means` implementation * Fix linter * Refactor `LRSinkhorn` initializers * Use `if` for `is_entropic`, remove dead variables * Slightly improve types * Do not use stateful `gamma` * Fix typo in tests * Fix using `state.gamma` instead of `self.gamma` * Fix point cloud size in notebook * Add assertion to k-means * Use `jax.lax.cond` instead of `jax.numpy.where` * Change convergence criterion * Use safe log * Fix more tests * Fix tests * Fix `tree_flatten` in `KMeansInitializer` * Fix defaults, change `rank_2` -> `rank2` * Simplify `apply` * Update TODOs * Update docs, make `lr_costs` private * Increate tolerance in failing test * Update LR notebook * Address comments * Remove LR Sinkhorn notebook from testing, to slow Co-authored-by: Michal Klein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the implementations of the update for the lr-sinkhorn algorithm: