Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fast tests #101

Merged
merged 53 commits into from
Jul 8, 2022
Merged

Feature/fast tests #101

merged 53 commits into from
Jul 8, 2022

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Jul 7, 2022

In this PR:

  • remove absl-py dependency, use only pytest
  • fix some tests having unused test arguments
  • consolidate tests into smaller number of files
  • mark some tests as fast and enable fast CI job
  • enable code coverage

closes #92

michalk8 added 30 commits July 4, 2022 12:48
@michalk8
Enable tests coverage
3e96ba4
@michalk8
Add fast test CI job
0f36469
@michalk8
Add coverage upload in CI
742e7db
@michalk8
Add custom fast mark handling
4327531
@michalk8
Fix typo in tests.yml
38b5417
@michalk8
Fix wrong test_mark identifier
7dd9526
@michalk8
Update continuous barycenter test
7c3eeb1
@michalk8
Update discrete barycenter
04a7314
@michalk8
Update FGW test, fix fixture handling
e4273dd
@michalk8
Update GW tests
7a02e2a
@michalk8
Update/move GW unbalanced test
5352c86
@michalk8
Update ICNN test
644c502
@michalk8
Update NeuralDualSolver tests
a2c2a17
@michalk8
Update Sinkhorn Anderson accel. test
3d949fd
@michalk8
Refactor Sinkhorn Bures test
23bf570
@michalk8
Refactor Sinkhorn differentiability tests
acd0121
@michalk8
Move and refactor grid diff + precond tests
0510a8c
@michalk8
Refactor and move Hessian tests
678143d
@michalk8
Move SinkhornJacobianApply test
0f3f054
@michalk8
Move implicit vs. autodiff tests
3643f35
@michalk8
Update SinkhornGrid test
9e02779
@michalk8
Update Sinkhorn jitting tests
5fdc509
@michalk8
Update LRSinkhorn test
b141445
@michalk8
Merge branch 'main' into feature/fast-tests
f72faa6
@michalk8
Move SinkhornOnline tests
476e96f
@michalk8
Move jacobian test
8a6fb7c
@michalk8
Move sinkhorn unbalanced tests
046ef88
@michalk8
Move Sinkhorn jitting tests, add chex as dep
e3c083b
@michalk8
Update Sinkhorn tests
7262eb0
@michalk8
Update TestCostFn
5aa2036
@michalk8 michalk8 added the enhancement New feature or request label Jul 7, 2022
@michalk8 michalk8 self-assigned this Jul 7, 2022
@michalk8 michalk8 marked this pull request as ready for review July 7, 2022 17:24
marcocuturi
marcocuturi approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Michal for this massive refactoring, this is extremely helpful... A lot of work!

@michalk8 michalk8 merged commit b218701 into ott-jax:main Jul 8, 2022
@michalk8 michalk8 deleted the feature/fast-tests branch July 8, 2022 12:56
michalk8 added a commit that referenced this pull request Jun 27, 2024
@michalk8
Feature/fast tests (#101)
eba66be 
* Enable tests coverage

* Add fast test CI job

* Add coverage upload in CI

* Add custom fast mark handling

* Fix typo in tests.yml

* Fix wrong test_mark identifier

* Update continuous barycenter test

* Update discrete barycenter

* Update FGW test, fix fixture handling

* Update GW tests

* Update/move GW unbalanced test

* Update ICNN test

* Update NeuralDualSolver tests

* Update Sinkhorn Anderson accel. test

* Refactor Sinkhorn Bures test

* Refactor Sinkhorn differentiability tests

* Move and refactor grid diff + precond tests

* Refactor and move Hessian tests

* Move SinkhornJacobianApply test

* Move implicit vs. autodiff tests

* Update SinkhornGrid test

* Update Sinkhorn jitting tests

* Update LRSinkhorn test

* Move SinkhornOnline tests

* Move jacobian test

* Move sinkhorn unbalanced tests

* Move Sinkhorn jitting tests, add chex as dep

* Update Sinkhorn tests

* Update TestCostFn

* Update LRGeom test

* Update Geom LSE and PC apply tests

* Update PC apply test

* Update Matrix square root tests

* Update ScaleCost tests

* Update SinkhornDivGrad test

* Update SinkhornDivergece output and tests

* Update soft sort and transport tests

* Update GMM pair test

* Fix typo, update FitGMM tests

* Update GMM pair test

* Update Gaussian Mixture test

* Update TestGaussian

* Update lingalg tests

* Update probabilities test

* Refactor ScaleTriL tests

* Remove absl-py from requirements

* Add .codecov.yml

* Fix typo in tests.yml

* Add coverage badge

* Fix type hint in 3.8

* Try using pytest-xdist

* Update pytest config, add --cov-append
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocuturi marcocuturi marcocuturi approved these changes

Assignees

@michalk8 michalk8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marking fast tests
2 participants
@michalk8 @marcocuturi