Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update discrete_barycenter code #255

Closed
michalk8 opened this issue Feb 14, 2023 · 1 comment
Closed

Update discrete_barycenter code #255

michalk8 opened this issue Feb 14, 2023 · 1 comment
Assignees
@marcocuturi
Labels
hackathon

Comments

@michalk8
Copy link
Collaborator

Should follow the paradigm we use - solver class + outputs.
@marcocuturi marcocuturi self-assigned this Feb 23, 2023
@marcocuturi marcocuturi mentioned this issue Feb 23, 2023
Merged
michalk8 added a commit that referenced this issue Feb 24, 2023
@marcocuturi @michalk8
Refactor discrete_barycenter as solver, cf. issue #255 (#316)
9bd2fe9 
* refactor discrete_barycenter as solver

* docs

* docs

* feat: add progress reporting to Sinkhorn (#228) (#317)

* fix: revert previous changes

* test: add tests for callback

* test: add tests for callback

* doc: misc improvements

* take into account review comments

* [ci skip] add minimal docs/utils.rst

* additional cleanup

* more robust tests

---------

Co-authored-by: bosr <[email protected]>
Co-authored-by: rbossart <[email protected]>

* incorporate comments

* comments

* incorporate comments, use FreeWassersteinBarycenter

* update

* [ci skip] Fix link in docs

---------

Co-authored-by: Michal Klein <[email protected]>
@michalk8
Copy link
Collaborator Author

closed via #316

michalk8 added a commit that referenced this issue Jun 27, 2024
@marcocuturi @michalk8
Refactor discrete_barycenter as solver, cf. issue #255 (#316)
edf98d1 
* refactor discrete_barycenter as solver

* docs

* docs

* feat: add progress reporting to Sinkhorn (#228) (#317)

* fix: revert previous changes

* test: add tests for callback

* test: add tests for callback

* doc: misc improvements

* take into account review comments

* [ci skip] add minimal docs/utils.rst

* additional cleanup

* more robust tests

---------

Co-authored-by: bosr <[email protected]>
Co-authored-by: rbossart <[email protected]>

* incorporate comments

* comments

* incorporate comments, use FreeWassersteinBarycenter

* update

* [ci skip] Fix link in docs

---------

Co-authored-by: Michal Klein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcocuturi marcocuturi

Labels
hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcocuturi @michalk8