Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if results: | ||
| return results[0] | ||
| return None | ||
| return results[0] if results else None |
There was a problem hiding this comment.
Function Queue.apply refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-572
to
+570
| if not pending_job_keys: | ||
| return True | ||
|
|
||
| return False | ||
| return not pending_job_keys |
There was a problem hiding this comment.
Function Queue.map refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
| resp = await handler(request) | ||
| return resp | ||
| return await handler(request) |
There was a problem hiding this comment.
Function exceptions refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-130
to
+129
| password = os.environ.get("AUTH_PASSWORD") | ||
|
|
||
| if password: | ||
| if password := os.environ.get("AUTH_PASSWORD"): |
There was a problem hiding this comment.
Function create_app refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| if not info.get("name") == queue.name: | ||
| if info.get("name") != queue.name: |
There was a problem hiding this comment.
Function async_check_health refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
| self.assertEqual( | ||
| set(q["name"] for q in json["queues"]), {"queue1", "queue2"} | ||
| ) | ||
| self.assertEqual({q["name"] for q in json["queues"]}, {"queue1", "queue2"}) |
There was a problem hiding this comment.
Function TestWorker.test_queues refactored with the following changes:
- Replace list(), dict() or set() with comprehension (
collection-builtin-to-comprehension)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!