Fix depot memory leak

[nekiro]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fix #3346

Issues addressed:
Removed memory leak

How to test:
Add item to first slot of your depot, preferably backpack (can be nested).
Spam the code below lots of times. I've tested with 360 pages of full backpacks, which adds like 50mb to memory, after few relogs memory was not increased.

local chest = player:getDepotChest(0)
local item = chest:getItem(0)

for i = 1, 500 do
	chest:addItemEx(item:clone(), INDEX_WHEREEVER, FLAG_NOLIMIT)
end

[ArturKnopik]

Are depos cached somehow? I see memory allocation but not deallocation after logout, relogging does not re-allocate new memory.

[ramon-bernardo]

@ArturKnopik this allocation, if I remember correctly, its related to IOLogin, where it adds the items to the vectors to save them

See,

I see a small memory spike whenever a player join/leave the game. It ranges from 3Mb at minimum to 15Mb at maximum, which is pretty strange

[ramon-bernardo]

The memory leak in the depot has been fixed. Check below to see how it was before. (never deallocate)

Note that there’s still a small leak, around 3mb to 15mb, every time a player login into server. This can be investigated later, as the current fix a more significant issue

[nekiro]

Noticed the small leak too, didn't really investigate what causes it, but I might at some point. It's not really related though.

[ArturKnopik]

Valgrind report when login and logout
items in many dp bp of bps
leaks.log