Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted positions introduced in #4648 #4674

Merged
merged 1 commit into from
May 7, 2024

Conversation

MillhioreBT
Copy link
Contributor

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

I don't know if more tests are needed, but when this PR #4648 was merged apparently the npc, monsters always turn their back on the player, in fact there are things that seem to be broken, the directional spells don't work, if someone can check with exevo vis hur ect...

It was simply a pair of inverted variables.

Issues addressed: Nothing!

@MillhioreBT MillhioreBT requested review from ranisalt and EvilHero90 May 7, 2024 12:47
@MillhioreBT MillhioreBT changed the title Fix Spells/CreatureLook/ect... directions fixing inverted positions introduced in #4648 May 7, 2024
@EvilHero90 EvilHero90 changed the title fixing inverted positions introduced in #4648 Fix inverted positions introduced in #4648 May 7, 2024
@MillhioreBT MillhioreBT merged commit a8afbd4 into otland:master May 7, 2024
19 checks passed
@MillhioreBT MillhioreBT deleted the fix_check_distances branch May 7, 2024 14:16
@ranisalt
Copy link
Member

ranisalt commented May 7, 2024

I don't know if more tests are needed

Always!

@ArturKnopik ArturKnopik mentioned this pull request Jun 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants