Added Loyalty System (10.74) #4636
Conversation
ghost
requested review from
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| void Player::setLoyaltyBonusSkill(uint8_t skill) | ||
| { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
|
|
||
| Skill Vocation::getSkillByAccumulatedTries(uint8_t skill, uint64_t tries) | ||
| { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
|
|
||
| uint64_t Vocation::getAccumulatedReqSkillTries(uint8_t skill, uint16_t level) | ||
| { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
| @@ -140,7 +140,7 @@ | |||
|
|
|||
| uint64_t Vocation::getReqSkillTries(uint8_t skill, uint16_t level) | |||
| { | |||
| if (skill > SKILL_LAST) { | |||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { | |||
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
| float ConfigManager::getLoyaltyBonus(uint16_t points) const | ||
| { | ||
| auto it = std::find_if(loyaltyBonuses.begin(), loyaltyBonuses.end(), [points](auto&& bonus) { | ||
| auto&& [minPoints, maxPoints, _] = bonus; |
Check notice
Code scanning / CodeQL
Unused local variable Note
| float ConfigManager::getLoyaltyBonus(uint16_t points) const | ||
| { | ||
| auto it = std::find_if(loyaltyBonuses.begin(), loyaltyBonuses.end(), [points](auto&& bonus) { | ||
| auto&& [minPoints, maxPoints, _] = bonus; |
Check notice
Code scanning / CodeQL
Unused local variable Note
Pull Request Prelude
Changes Proposed
Issues addressed:
#3871 Version 10.74 (The Loyalty System was introduced.)