Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for filename in load*XML functions #4357

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ArturKnopik
Copy link
Contributor

@ArturKnopik ArturKnopik commented Mar 28, 2023

Issues addressed:
Fixes #4347

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

@ghost ghost requested review from ranisalt, nekiro and DSpeichert March 28, 2023 18:23
@ghost ghost added the bugfix label Mar 28, 2023
@MillhioreBT
Copy link
Contributor

This only happens on old compilers, I have this error too, but I keep this change local and nothing happens.
TFS is not to blame for us having dinosaurs

@ArturKnopik
Copy link
Contributor Author

vs 19 is not that old :D

@MillhioreBT
Copy link
Contributor

vs 19 is not that old :D

I thought the same thing. It would be great if this solution could be applied temporarily for those of us who still use older compilers. This way, it is more comfortable to test changes without having to make corrections and then remove them to make them compatible with master.

@ghost
Copy link

ghost commented Mar 29, 2023

if this doesn't affect anything else, I see no problem in implementing

@ranisalt
Copy link
Member

vs 19 is not that old :D

It's not the age, it's because the implementation of the standard library is super quirky. For example, the iterators in std::array<T, N> are not simply T* as they are in gcc/clang, Microsoft implements something else that isn't compatible.

That caused some issues in #4043, since fixed, but it's annoying to maintain unexpected things :(

@ranisalt ranisalt changed the title fix issue 4347 Fix type for filename in load*XML functions Mar 29, 2023
@ranisalt ranisalt merged commit 23ab424 into otland:master Mar 29, 2023
ArturKnopik pushed a commit to ArturKnopik/forgottenserver that referenced this pull request Apr 2, 2023
This reverts commit 09520e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling errors
3 participants