WIP: Highscores #4152
Closed
WIP: Highscores #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs testing & code review
|
This could be done using DatabaseTasks to make it async. |
ghost
requested review from
ranisalt
reviewed
Jun 4, 2022
| } | ||
|
|
||
| scriptInterface.resetScriptEnv(); | ||
| } |
There was a problem hiding this comment.
I believe you can do the network messaging in Lua and avoid messing with the table here. Something in #4043 might be helpful
There was a problem hiding this comment.
Do you mean sending the HighscoresWindow part or handling the packets received from the client?
There was a problem hiding this comment.
I mean Player:onRequestHighscores should return nothing, and should create a NetworkMessage and fill it in Lua instead of returning a table and filling the network message in C++
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Needs testing, suggestions & code review
Issues addressed:
Highscores functionality