Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weird std::move #3471

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix weird std::move #3471

merged 1 commit into from
May 26, 2021

Conversation

nekiro
Copy link
Member

@nekiro nekiro commented May 26, 2021

This code does nothing, pretty much. Use const reference and assign instead of copying and moving.

@DSpeichert DSpeichert merged commit 9fd6c8e into master May 26, 2021
@DSpeichert DSpeichert deleted the nekiro-patch-1 branch May 26, 2021 23:12
@Znote Znote mentioned this pull request Jun 5, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSpeichert DSpeichert DSpeichert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekiro @DSpeichert