Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tolerent conversion jsontosdp #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

more tolerent conversion jsontosdp #21

wants to merge 1 commit into from

Conversation

mpromonet
Copy link

Hi,

Please find these 2 little modification that accept to convert from JSON to SDP:

  • when a group is defined but has not content
  • consider datachanel when media is "application" and applciationtype="rtp"

I made these modifications in order to convert to SDP a session-initiate send by jitsi.

Best Regards,
Michel.

@xdumaine
Copy link

Looks good to me, but could you add tests for this? @legastero @fippo do you see any problems with this?

@fippo
Copy link
Member

fippo commented Jul 16, 2018

how does the session-initate look like? A group without contents smells buggy but 👍 on being more robust

@mpromonet
Copy link
Author

Maybe I do something wrong, but in my test the session-initiate always contains :

 "groups":[{"semantics":"BUNDLE"}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants