fix: false positives for for attr in `astro/jsx-a11y/label-has-asso…

…ciated-control` rule (#126)

* fix: false positives for `for` attr in `astro/jsx-a11y/label-has-associated-control` rule

* add test

* Create many-dodos-grin.md

* fix

.changeset/many-dodos-grin.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-astro": patch
+---
+
+fix: false positives for `for` attr in `astro/jsx-a11y/label-has-associated-control` rule

src/a11y/rules.ts

@@ -16,6 +16,7 @@ const ATTRIBUTE_MAP: Record<string, string | undefined> = {
   "set:html": "dangerouslySetInnerHTML",
   "set:text": "children",
   autofocus: "autoFocus",
+  for: "htmlFor",
 }
 
 /** Get `eslint-plugin-jsx-a11y` rule. */

tests/fixtures/rules/jsx-a11y/label-has-associated-control/invalid/test01-errors.json

@@ -0,0 +1,7 @@
+[
+  {
+    "message": "A form label must be associated with a control.",
+    "line": 5,
+    "column": 1
+  }
+]

tests/fixtures/rules/jsx-a11y/label-has-associated-control/invalid/test01-input.astro

@@ -0,0 +1,6 @@
+---
+const domId = "foo"
+---
+
+<label>Surname</label>
+<input type="text" id={domId} />

tests/fixtures/rules/jsx-a11y/label-has-associated-control/valid/issue123-input.astro

@@ -0,0 +1,9 @@
+---
+---
+
+<form>
+  <label class="label" for="address">Address</label>
+  <textarea placeholder="Address" required name="address" id="address"
+  ></textarea>
+  <input type="submit" value="Submit" />
+</form>

tests/fixtures/rules/jsx-a11y/label-has-associated-control/valid/test01-input.astro

@@ -0,0 +1,10 @@
+---
+const domId = "foo"
+---
+
+<label>
+  Surname
+  <input type="text" />
+</label>
+<label for={domId}>Surname</label>
+<input type="text" id={domId} />

tests/src/rules/jsx-a11y/label-has-associated-control.ts

@@ -0,0 +1,20 @@
+import { RuleTester } from "eslint"
+import { rules } from "../../../../src/utils/rules"
+import { loadTestCases } from "../../../utils/utils"
+
+const rule = rules.find(
+  (r) => r.meta.docs.ruleName === "jsx-a11y/label-has-associated-control",
+)!
+
+const tester = new RuleTester({
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: "module",
+  },
+})
+
+tester.run(
+  "jsx-a11y/label-has-associated-control",
+  rule as any,
+  loadTestCases("jsx-a11y/label-has-associated-control"),
+)