-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support glob in project
key
#304
Conversation
🦋 Changeset detectedLatest commit: 61c369e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! I have one thing to worry about.
// typescript doesn't provide a ts.sys implementation for browser environments | ||
const useCaseSensitiveFileNames = | ||
ts.sys !== undefined ? ts.sys.useCaseSensitiveFileNames : true; | ||
const correctPathCasing = useCaseSensitiveFileNames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably need to rewrite it like this:
let correctPathCasing = (filePath: string): string => {
const ts: TS = createRequire(path.join(process.cwd(), "__placeholder__.js"))(
"typescript",
);
const useCaseSensitiveFileNames = ts.sys !== undefined ? ts.sys.useCaseSensitiveFileNames : true;
correctPathCasing = useCaseSensitiveFileNames
? (filePath: string): string => filePath
: (filePath: string): string => filePath.toLowerCase();
return correctPathCasing(filePath);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the unbelievable mistake of producing the same error in a different way. Thank you 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much!
Fix: ota-meshi/eslint-plugin-astro#342
Code from: