Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User friendly error visualization #98

Merged
merged 5 commits into from
Feb 17, 2024
Merged

User friendly error visualization #98

merged 5 commits into from
Feb 17, 2024

Conversation

AkinariHex
Copy link
Collaborator

@AkinariHex AkinariHex commented Feb 17, 2024 •
edited
Loading

With this PR I made several changes:

  • navbar hidden when user is unauthorized
  • implemented error context that catches errors and shows them through toast
  • default README.md changed

firefox_eAReUxoUyx

closes #97

@AkinariHex AkinariHex requested a review from hburn7 February 17, 2024 12:13
hburn7
hburn7 requested changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@hburn7 hburn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, looks fine otherwise.

README.md Outdated Show resolved Hide resolved
@hburn7 hburn7 merged commit 15e0820 into osu-tournament-rating:develop Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hburn7 hburn7 hburn7 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkinariHex @hburn7