Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tournament submission to use the otr-api-client #231

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

myssto
Copy link
Contributor

@myssto myssto commented Dec 2, 2024

Closes #222

Models how I would go about refactoring the site to use the new client package starting with the tournament submission form. Everything related is now 100% type safe and refactorable.

Changes:

  • Refactor the locations of some components to be more consistent
  • Start abstracting some of the content in @/lib to improve readability
  • Rearrange some of the fields on the tournament submission form
  • Improve the error detail for malformed form submissions
  • Add a form field for submitting beatmap ids

Changes that still need to be done:

  • Allow admins to submit with no mp links
  • Allow admins to submit with a rejection reason
    • Investigate usage of bitwise enums in zod / in the codebase in general
  • Improve the info icon text for the mp and beatmap links fields

@AkinariHex
Copy link
Collaborator

The Changes that still need to be done will be done here or later in the future?

@myssto myssto merged commit 642c4e3 into master Dec 6, 2024
@hburn7 hburn7 deleted the beatmap-submission branch December 6, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add input for tournament beatmap ids submission
2 participants