-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor session handling #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot of changes applied but we watched together these changes a little bit, like that we made a big refactor.
I feel good with that if you tested that works as before, also we can check last things together if unsure.
Please ensure things aren't "more broken" than they were before, if possible. |
This is why I am waiting myssto, I want to merge the PR with him in a call so we can see if something is broken and hotfix it. |
Unblocks osu-tournament-rating/otr-api#476
Closes #134
Part of #220
All of the changed code that makes calls to the otr-api now use the
@osu-tournament-rating/otr-api-client
package. These changes break almost everything on the site because of the partial adoption of the api client package, but @AkinariHex and I have agreed that is fine for now. Once this is merged we will work on refactoring the rest of the server side code to adopt the api client.Changes: