Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New charts #188

Merged
merged 33 commits into from
Jun 23, 2024
Merged

New charts #188

merged 33 commits into from
Jun 23, 2024

Conversation

AkinariHex
Copy link
Collaborator

@AkinariHex AkinariHex commented May 16, 2024

This PR will address a lot of bugs regarding the charts in the dashboard/user page.
There was a plan for a new chart that for now is in standby/not gonna be used for now.

This contain other fixes to layout and adding bunch of new UI that were added in the figma design.

Requires the new changes from otr-api about the change from worstTournamentPerformances to recentTournamentPerformances

Todo

  • Change color for line bar graphs
  • Add tooltip in some graphs

@hburn7
Copy link
Collaborator

hburn7 commented May 21, 2024

#170 & #86 look good enough for beta.

@hburn7
Copy link
Collaborator

hburn7 commented Jun 13, 2024

@AkinariHex Is this still being worked on? I'd like to get this out of a draft state.

@AkinariHex AkinariHex marked this pull request as ready for review June 18, 2024 15:26
@AkinariHex AkinariHex requested a review from hburn7 June 18, 2024 15:27
@hburn7
Copy link
Collaborator

hburn7 commented Jun 18, 2024

I think this mostly looks good, a few points of feedback:

  • All bar charts need to have padding on the end. It seems like some charts have the padding depending on the profile you are browsing. My profile, bento's profile, and cytusine's profile all have charts that fill up the entire chart with no padding. Some charts do not have padding regardless of which profile is being browsed. Ensure all charts on all profiles have the proper padding before merging.
  • If possible, I would really like to see the rounded profile pictures before merging.

Figma:
image

Website (my profile):
image

@hburn7
Copy link
Collaborator

hburn7 commented Jun 18, 2024

Additionally, is there a way to fix this missing line? Why does it go from 1.8 to 2.1? (worst hr player)
image

@AkinariHex
Copy link
Collaborator Author

Additionally, is there a way to fix this missing line? Why does it go from 1.8 to 2.1? (worst hr player) image

For this one, I was pretty sure I made a fix for this problem, and with the data I had it was working, I will check it again

@AkinariHex
Copy link
Collaborator Author

For charts without padding and without rounded images I will try to do my best to implement before merge

@hburn7
Copy link
Collaborator

hburn7 commented Jun 23, 2024

Looks great.

@hburn7 hburn7 merged commit b1c8db6 into master Jun 23, 2024
@hburn7 hburn7 deleted the new-charts branch July 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants