Add stub for new libglnx tmpfile API, port simpler callers to it #871
Conversation
|
This can come after #865 |
|
So looking at the codebase, it seems like there's only 3 other instances where that API is used, right? It feels like it would be simpler than just do it all in one PR (even if it takes time) rather than carry a wrapper API and freeze libglnx? Or do you feel like those other 3 instances are especially complex? |
|
The problem is the commit codepath which uses |
src/libotutil/ot-fs-utils.c
Outdated
| @@ -25,6 +25,54 @@ | |||
| #include <sys/xattr.h> | |||
| #include <gio/gunixinputstream.h> | |||
|
|
|||
| /* Stub out old libglnx API to new one */ | |||
There was a problem hiding this comment.
Can we expand on this a bit? E.g.
Wrapper around libglnx API, which doesn't clean up properly.
This was fixed in https://github.com/GNOME/libglnx/commit/9929adc, though
it's API breaking. Carry the fix here until we're ready to fully port.
?
There was a problem hiding this comment.
Did that, also rebased on the new version of the API and cleaned up. ⬇️
This was a copy-paste-o.
It's hard right now to do a full port to the new libglnx tmpfile API since there are complex cases in the commit path which deal with symlinks as well. Let's make things more gradual by introducing the important part (struct with autocleanup) here in libotutil, port what we can. This will make a future complete port easier.
cgwalters
force-pushed
the
glnx-tmpfile-prep
branch
from
c979a06 to
e4b8282
Compare
It's hard right now to do a full port to the new libglnx tmpfile API since there are complex cases in the commit path which deal with symlinks as well. Let's make things more gradual by introducing the important part (struct with autocleanup) here in libotutil, port what we can. This will make a future complete port easier. Closes: #871 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
It's hard right now to do a full port to the new libglnx tmpfile
API since there are complex cases in the commit path which deal
with symlinks as well.
Let's make things more gradual by introducing the important part (struct with
autocleanup) here in libotutil, port what we can. This will make a future
complete port easier.