tests/installed: New installed, privileged tests using Fedora AH #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be shared more easily with e.g. rpm-ostree, but what I'm currently working on is installed, privileged (potentially destructive, i.e. VM) tests that will source this separately from the current `libtest.sh`. That does work installed, but in practice is oriented around unit (uninstalled, unprivileged) tests.
Our container-driven tests can't e.g. test SELinux sanely, and have to support being run as root *and* non-root too. Use redhat-ci to provision a VM and run tests directly there. These are installed tests too. Closes: ostreedev#806
jlebon
reviewed
Apr 25, 2017
tests/installed/libinsttest.sh
Outdated
| assert_streq $(id -u) 0 | ||
|
|
||
| PYTHON= | ||
| for PYTHON in /usr/bin/python3 /usr/bin/python; do |
There was a problem hiding this comment.
Maybe use a different placeholder var here, otherwise the test -z below will never fail.
|
This is really nice! |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our container-driven tests can't e.g. test SELinux sanely, and
have to support being run as root and non-root too.
Use redhat-ci to provision a VM and run tests directly there. These are
installed tests too.