Two sepolicy API improvements #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably e665e51) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm porting other code away from `GFile`, and while we don't use this internally, it will let us do so at a later date. I'm averse to changing the code right now as we don't have good CI coverage of this.
Use `g_auto()` more sanely with a struct implmenting the "is initialized" pattern. This is way less ugly for callers, and fixes bugs like us calling `setfscreatecon()` even if an error occurred beforehand. Also fold in the logic for "NULL or not loaded" sepolicy into the setup rather than requiring callers to inline it. Prep for more users of this function.
|
🏄 Rebased |
|
Code looks good. The flakes are really starting to get cumbersome though. I opened #751 for that. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 22, 2017
Use `g_auto()` more sanely with a struct implmenting the "is initialized" pattern. This is way less ugly for callers, and fixes bugs like us calling `setfscreatecon()` even if an error occurred beforehand. Also fold in the logic for "NULL or not loaded" sepolicy into the setup rather than requiring callers to inline it. Prep for more users of this function. Closes: #746 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #741