checkout: Support a "pure addition" mode #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP due to lack of tests, cmdline wrapper. |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 2, 2017
WIP due to missing tests and docs. But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 2, 2017
WIP due to missing tests and docs. But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
4 tasks
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 2, 2017
WIP due to missing tests and docs. But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
|
Now with tests ✅ - removing WIP. |
jlebon
reviewed
Mar 6, 2017
src/libostree/ostree-repo-checkout.c
Outdated
| { | ||
| /* In this mode, we keep existing content. Still need to mark the hardlink as supported. | ||
| */ | ||
| ret_was_supported = TRUE; |
There was a problem hiding this comment.
One concern with this is that the kernel checks for EEXISTS before checking whether hardlinking is supported. So we can't really assert this, right? Looking at checkout_one_file_at(), it relies on this info to update the devino cache, which will be wrong after this. Maybe add e.g. out_exists also so callers can distinguish this?
There was a problem hiding this comment.
Oooh. That's a good catch. That would have been spectacularly painful to debug later.
|
Ok, rebased 🏄, added a prep patch and a fixup. |
jlebon
reviewed
Mar 6, 2017
src/libostree/ostree-repo-checkout.c
Outdated
| cancellable, error)) | ||
| { | ||
| g_prefix_error (error, "Using new cached uncompressed hardlink of %s to %s: ", checksum, destination_name); | ||
| goto out; | ||
| } | ||
|
|
||
| need_copy = !did_hardlink; | ||
| need_copy = hardlink_res == HARDLINK_RESULT_NOT_SUPPORTED; |
|
Nice! Looks like some tests might need to be adjusted to grep for the new error message. |
At least in all Linux kernels up to today, one can never `link()` across devices, so we might as well verify that up front. This will help for a future patch to add a new type of union-add checkout, since Linux checks for `EEXIST` before `EXDEV`.
I plan to use this for `rpm-ostree livefs`. coreos/rpm-ostree#639
|
Eh, my fixups went wrong, I just squashed to simplify. One of the bugs was we need to initialize |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 6, 2017
I plan to use this for `rpm-ostree livefs`. coreos/rpm-ostree#639 Closes: #714 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 11, 2017
WIP due to missing tests and docs. But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 16, 2017
WIP due to missing tests and docs. But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 17, 2017
WIP due to missing tests and docs. But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 18, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 20, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 22, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 22, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 23, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 24, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 27, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 27, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 20, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 26, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 27, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 28, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 28, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
May 1, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
May 1, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
May 8, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
May 9, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
May 10, 2017
But I've been playing with this interactively, and it's at a useful place already. The primary target here is supporting live addition of new packages, while *also* allowing people to do completely arbitrary replacement if that's what they want. Depends: GNOME/libglnx#36 ostreedev/ostree#714 Closes: coreos#639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to use this for
rpm-ostree livefs.coreos/rpm-ostree#639