[merged] tests: Alias assert_not_reached() -> fatal() #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a lot of copies of the "echo something 1>&2; exit 1" code even though `assert_not_reached()` was it. Hence, I think we need a shorter alias for that. Doing this particularly since I noticed a missing `1` in an `exit 1` call in the rpm-ostree copy of this.
|
Boy, even Travis is happy for a change! |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Jan 19, 2017
We had a lot of copies of the "echo something 1>&2; exit 1" code even though `assert_not_reached()` was it. Hence, I think we need a shorter alias for that. Doing this particularly since I noticed a missing `1` in an `exit 1` call in the rpm-ostree copy of this. Closes: ostreedev#648 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a lot of copies of the "echo something 1>&2; exit 1" code even though
assert_not_reached()was it. Hence, I think we need a shorter alias for that.Doing this particularly since I noticed a missing
1in anexit 1call in therpm-ostree copy of this.