-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[merged] Move ostree-* executables to /usr/lib/ostree #449
Conversation
Can one of the admins verify this patch?
|
Still testing, but so far looks good. I assume this requires changing something in ostree/packaging/ostree.spec.in as well, but I am not sure how to test that. Edit: Tested and works fine for me. |
78413d1
to
815cea4
Compare
Hmm, this would break rpm-ostree at least which assumes that it can create So it seems like it's easier to make it |
Correct.
Moving it to |
815cea4
to
653f36a
Compare
Why not to use libexecdir? Because this directory does not exist on some distros or paths between distros varies. There are several reasons why a well known path is prefered, for example when generating a kernel command line: init=${ostree}/usr/lib/ostree-boot/ostree-prepare-root In addition this saves us some typing in a console when wanting to access the "ostree" cmd line.
653f36a
to
730aa2e
Compare
LGTM, thanks! |
☀️ Test successful - status-atomicjenkins |
The "ostree-boot" directory is for boot related files. Therefore is
a more appropriate place for ostree-{prepare-root,remount,grub-generator}
executibles and in addition saves us some typing in a console
when wanting to access the "ostree" cmd line.
Why not to use libexecdir instead? Because this directory does not
exist on some distros or paths between distros varies. There are several
reasons why a well known path is prefered (for example when passing
init=${ostree}/usr/lib/ostree-boot/ostree-prepare-root via kernel
command line).