Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merged] Move ostree-* executables to /usr/lib/ostree #449

Closed
wants to merge 1 commit into from

Conversation

gatispaeglis
Copy link
Contributor

@gatispaeglis gatispaeglis commented Aug 9, 2016

The "ostree-boot" directory is for boot related files. Therefore is
a more appropriate place for ostree-{prepare-root,remount,grub-generator}
executibles and in addition saves us some typing in a console
when wanting to access the "ostree" cmd line.

Why not to use libexecdir instead? Because this directory does not
exist on some distros or paths between distros varies. There are several
reasons why a well known path is prefered (for example when passing
init=${ostree}/usr/lib/ostree-boot/ostree-prepare-root via kernel
command line).

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following comments:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@gatispaeglis
Copy link
Contributor Author

gatispaeglis commented Aug 9, 2016

Still testing, but so far looks good. I assume this requires changing something in ostree/packaging/ostree.spec.in as well, but I am not sure how to test that.

Edit: Tested and works fine for me.

@cgwalters
Copy link
Member

Hmm, this would break rpm-ostree at least which assumes that it can create /usr/lib/ostree-boot by moving the legacy /boot location. I think we can teach it not to do that but...we never want this content to actually end up on /boot, right?

So it seems like it's easier to make it /usr/lib/ostree or so, which is what non-libexec distros like Debian typically use anyways.

@gatispaeglis
Copy link
Contributor Author

gatispaeglis commented Aug 9, 2016

we never want this content to actually end up on /boot, right?

Correct.

So it seems like it's easier to make it /usr/lib/ostree or so

Moving it to /usr/lib/ostree is a good solution too. I will update the patch accordingly.

@cgwalters cgwalters changed the title Move ostree-* executables to /usr/lib/ostree-boot Move ostree-* executables to /usr/lib/ostree Aug 9, 2016
Why not to use libexecdir?

Because this directory does not exist on some distros or paths
between distros varies. There are several reasons why a well
known path is prefered, for example when generating a kernel
command line:

init=${ostree}/usr/lib/ostree-boot/ostree-prepare-root

In addition this saves us some typing in a console when wanting
to access the "ostree" cmd line.
@cgwalters
Copy link
Member

LGTM, thanks!

@rh-atomic-bot r+ 730aa2e

@rh-atomic-bot
Copy link

⌛ Testing commit 730aa2e with merge fd1a044...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing fd1a044 to master...

@rh-atomic-bot rh-atomic-bot changed the title Move ostree-* executables to /usr/lib/ostree [merged] Move ostree-* executables to /usr/lib/ostree Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants