Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fixes & SPDX identifiers uniformisation #3185

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Docs fixes & SPDX identifiers uniformisation #3185

merged 3 commits into from
Feb 22, 2024

Conversation

travier
Copy link
Member

@travier travier commented Feb 20, 2024

docs: Consistently use SPDX identifiers

Standardize on a single SPDX identifier in a comment at the top.

docs: Misc whitespace fixes

README & docs: Sync README and docs index page

jmarrero
jmarrero approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero
Copy link
Member

/lgtm
/override ci/prow/fcos-e2e

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

@jmarrero: jmarrero unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/lgtm
/override ci/prow/fcos-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon
Copy link
Member

jlebon commented Feb 22, 2024

/override ci/prow/fcos-e2e

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 22, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/fcos-e2e

In response to this:

/override ci/prow/fcos-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuijingHei HuijingHei merged commit 311def5 into ostreedev:main Feb 22, 2024
24 checks passed
@travier travier deleted the main-docs-spdx-fixes branch February 24, 2024 14:49
travier added a commit to travier/ostree that referenced this pull request Feb 24, 2024
@travier
docs: Move SPDX identifiers under first title
4ae5065 
Having a comment right before the first title apparently confuses
Jekyll.

Fixes: ostreedev#3185
@travier travier mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@jmarrero jmarrero jmarrero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@travier @jmarrero @jlebon @HuijingHei