prepare-root: check return codes for errors when assembling paths #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The suggestion in the review here was to introduce an infallible wrapping helper, but I'd rather not add more variadic complexity nor preprocessor macro magic. Longer term, if we want to do a cleanup pass on this logic, I think a better investment effort would be porting to the usual glib helpers instead. |
jlebon
approved these changes
Oct 26, 2021
|
Needs a rebase |
This adds checks around all `snprintf` calls in order to detect failures and gracefully abort.
lucab
force-pushed
the
ups/prepare-root-checked-printf
branch
from
a2ca907 to
ca84da6
Compare
|
Rebased. |
jlebon
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks around all
snprintfcalls in order to detectfailures and gracefully abort.