Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: Use g_new for OstreeRepoAutoLock #2370

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

dbnicholson
Copy link
Member

GSlice is effectively deprecated and has little to no advantage over
using the system allocator on Linux.

This was discussed in #2348 (comment). I started swapping out all the GSlice usage tree-wide, but I wasn't totally sure if that was wanted. If you prefer, I can finish that off.

GSlice is effectively deprecated and has little to no advantage over
using the system allocator on Linux.
@dbnicholson
Copy link
Member Author

This was discussed in #2348 (comment). I started swapping out all the GSlice usage tree-wide, but I wasn't totally sure if that was wanted. If you prefer, I can finish that off.

However, for full disclosure I looked at the GSlice usage in https://github.com/ostreedev/ostree/blob/main/src/libotutil/ot-variant-builder.c and it seemed like it was fairly intimately connected to the code in question. The other usages in libostree were straightforward allocations.

@dbnicholson
Copy link
Member Author

Travis/Dockerhub rate limiting failure... This is a simple change, so merging rather than waiting for the planets to align.

@dbnicholson dbnicholson merged commit 3d66db2 into ostreedev:main Jun 7, 2021
@dbnicholson dbnicholson deleted the auto-lock-no-gslice branch June 7, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants