Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow/release: further refinements #2243

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

lucab
Copy link
Member

@lucab lucab commented Nov 18, 2020

This tweaks the release GH workflow further so that it only triggers
when the configure.ac file (which owns the version) changes.
Plus it properly checkouts the PR branch to avoid wrongly looking
at a synthetic merge commit.

Ref: #2241 (comment)

/cc @jlebon

This tweaks the release GH workflow further so that it only triggers
when the `configure.ac` file (which owns the version) changes.
Plus it properly checkouts the PR branch to avoid wrongly looking
at a synthetic merge commit.
@lucab
Copy link
Member Author

lucab commented Nov 18, 2020

/test sanity

@jlebon
Copy link
Member

jlebon commented Nov 18, 2020

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, lucab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e33ada1 into ostreedev:master Nov 18, 2020
@lucab lucab deleted the ups/workflow-checkout branch November 18, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants