repo: Add checksum to error message opening unreadable object #1564
Conversation
This would have debugged trying to do a pull as non-root from a sysroot repository. See for example: ostreedev#1562
| ostree --repo=repo commit -b testbranch --tree=dir=files | ||
| # We should be able to read as non-root due to CAP_DAC_OVERRIDE | ||
| ostree --repo=repo ls testbranch >/dev/null | ||
| cat >upriv.sh <<EOF |
There was a problem hiding this comment.
This doesn't look used anywhere?
There was a problem hiding this comment.
Thanks, fixup for all of these ⬇️
| set -xeuo pipefail | ||
| ostree --repo=testclone | ||
| EOF | ||
| if setpriv --reuid bin --regid bin --clear-groups ostree --repo=repo cat testbranch /unreadable 2>err.txt; then |
There was a problem hiding this comment.
I'd be more convinced if we did the exact same cat testbranch /unreadable test also for root above. :)
| touch files/unreadable | ||
| chmod 0 files/unreadable | ||
| ostree --repo=repo commit -b testbranch --tree=dir=files | ||
| # We should be able to read as non-root due to CAP_DAC_OVERRIDE |
There was a problem hiding this comment.
This should say "read as root", right?
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
💔 Test failed - status-atomicjenkins |
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
💔 Test failed - status-atomicjenkins |
|
Hm, not sure what went wrong with that one. @rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
This would have debugged trying to do a pull as non-root from
a sysroot repository. See for example:
#1562