switchroot: Ensure /run/ostree-booted is created even without initramfs #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://mail.gnome.org/archives/ostree-list/2018-March/msg00012.html If ostree-prepare-root is run as pid 1 (i.e we're not using an initramfs), then anything we write outside the target sysroot (such as `/run/ostree-booted`) will be lost. Since `ostree-remount.service` runs fairly early in boot, and is triggered via `ConditionKernelCommandLine=ostree`, we can just touch the file there in addition.
|
@rh-atomic-bot delegate=akiernan |
|
✌️ @akiernan can now approve this pull request |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 22, 2018
See https://mail.gnome.org/archives/ostree-list/2018-March/msg00012.html If ostree-prepare-root is run as pid 1 (i.e we're not using an initramfs), then anything we write outside the target sysroot (such as `/run/ostree-booted`) will be lost. Since `ostree-remount.service` runs fairly early in boot, and is triggered via `ConditionKernelCommandLine=ostree`, we can just touch the file there in addition. Closes: #1508 Approved by: akiernan
|
💔 Test failed - status-atomicjenkins |
|
Blah, I'm going to have to debug that flake.
@rh-atomic-bot retry
|
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 22, 2018
See https://mail.gnome.org/archives/ostree-list/2018-March/msg00012.html If ostree-prepare-root is run as pid 1 (i.e we're not using an initramfs), then anything we write outside the target sysroot (such as `/run/ostree-booted`) will be lost. Since `ostree-remount.service` runs fairly early in boot, and is triggered via `ConditionKernelCommandLine=ostree`, we can just touch the file there in addition. Closes: #1508 Approved by: akiernan
|
💔 Test failed - status-atomicjenkins |
|
OK, fix for that flake is in #1509 |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Mar 22, 2018
A quick turnaround to include one PR: ostreedev#1508 "switchroot: Ensure /run/ostree-booted is created even without initramfs" This fixes ostree when booting without an initramfs. Thanks to @akiernan for the bug report and helping review the fix! I'm working on enhancing the test suite, which will help in adding some coverage here. Also for this release I'm going to avoid adding a "stub" symbol section to the `-released.sym` file; I don't believe it's necessary.
Closed
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 22, 2018
A quick turnaround to include one PR: #1508 "switchroot: Ensure /run/ostree-booted is created even without initramfs" This fixes ostree when booting without an initramfs. Thanks to @akiernan for the bug report and helping review the fix! I'm working on enhancing the test suite, which will help in adding some coverage here. Also for this release I'm going to avoid adding a "stub" symbol section to the `-released.sym` file; I don't believe it's necessary. Closes: #1512 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://mail.gnome.org/archives/ostree-list/2018-March/msg00012.html
If ostree-prepare-root is run as pid 1 (i.e we're not using an initramfs), then
anything we write outside the target sysroot (such as
/run/ostree-booted) willbe lost.
Since
ostree-remount.serviceruns fairly early in boot, and is triggered viaConditionKernelCommandLine=ostree, we can just touch the file there inaddition.