build-sys: Link with -ldl for rust build #1391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't dive into this too much, it looks like something in rust changed that broke our build. Probably libstd gained a dependency on `-ldl` or so, and that's handled by cargo? Anyways linking against it isn't going to hurt.
This reverts commit 8ef18fd.
|
Looks good to me. (Do I count as a reviewer?) |
|
@smcv: 🔑 Insufficient privileges: Collaborator required |
|
@rh-atomic-bot delegate=smcv |
|
✌️ @smcv can now approve this pull request |
|
⚡ Test exempted: pull fully rebased and already tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't dive into this too much, it looks like something in rust changed that
broke our build. Probably libstd gained a dependency on
-ldlor so, and that'shandled by cargo? Anyways linking against it isn't going to hurt.