lib/core: Add a "break hardlink" API #1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imports the code from rpm-ostree: https://github.com/projectatomic/rpm-ostree/blob/9ff9f6c997d914cb7d97d6b59d8045ba64a1882c/src/libpriv/rpmostree-util.c#L742 I plan to use this for rofiles-fuse to implement copyup: ostreedev#1377 But it's just obviously generally useful for projects using libostree I think.
It'd all be really nice if there was some sort of `O_TMPFILE` for symlinks, but anyways the way we were doing a generic "make temp file than rename" actually defeats some of the point of `O_TMPFILE`. It's now fully safe to do "copy to self", so let's do that for regfiles.
|
Tests are passing on this one now. |
|
Ahh, that's a nice use of |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 14, 2017
It'd all be really nice if there was some sort of `O_TMPFILE` for symlinks, but anyways the way we were doing a generic "make temp file than rename" actually defeats some of the point of `O_TMPFILE`. It's now fully safe to do "copy to self", so let's do that for regfiles. Closes: #1378 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Dec 15, 2017
The code moved into libostree here: ostreedev/ostree#1378
rh-atomic-bot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Dec 15, 2017
The code moved into libostree here: ostreedev/ostree#1378 Closes: #1154 Approved by: jlebon
rh-atomic-bot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Dec 15, 2017
The code moved into libostree here: ostreedev/ostree#1378 Closes: #1154 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the code from rpm-ostree:
https://github.com/projectatomic/rpm-ostree/blob/9ff9f6c997d914cb7d97d6b59d8045ba64a1882c/src/libpriv/rpmostree-util.c#L742
I plan to use this for rofiles-fuse to implement
copyup: #1377
But it's just obviously generally useful for projects using
libostree I think.