lib/deltas: Fix change to use pread() in write opcode #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 9345707 "lib/deltas: Use pread() instead of lseek()+read()" Caught this when trying to test alex's patch locally. I am going to review our static delta pulls and try to get something more comprehensive locally. But in the meantime this patch is clearly right.
|
Also 😢 at having to debug static deltas...man, how did I inflict that on myself. |
|
Ouhh, evil! |
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Oct 30, 2017
This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. coreos/rpm-ostree#470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without ostreedev#1312
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Oct 30, 2017
This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. coreos/rpm-ostree#470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without the fixup for `pread()` in ostreedev#1312
|
Test in #1314 |
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Nov 1, 2017
This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. coreos/rpm-ostree#470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without the fixup for `pread()` in ostreedev#1312
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 1, 2017
This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. coreos/rpm-ostree#470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without the fixup for `pread()` in #1312 Closes: #1314 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 9345707 "lib/deltas: Use pread() instead of lseek()+read()"
Caught this when trying to test alex's patch locally. I am going to review our
static delta pulls and try to get something more comprehensive locally. But in
the meantime this patch is clearly right.